rev_D functionality - Githubissues

analogdevicesinc / no-OS

Software drivers in C for systems without an operating system

http://analogdevicesinc.github.io/no-OS/

Other

922 stars 1.65k forks source link

rev_D functionality #2215

Closed raezt closed 3 months ago

raezt commented 3 months ago

Pull Request Description

Revision D firmware update.

PR Type

[ ] Bug fix (change that fixes an issue)
[x] New feature (change that adds new functionality)
[ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

[x] I have followed the Coding style guidelines
[x] I have performed a self-review of the changes
[x] I have commented my code, at least hard-to-understand parts
[x] I have build all projects affected by the changes in this PR
[x] I have tested in hardware affected projects, at the relevant boards
[x] I have signed off all commits from this PR
[ ] I have updated the documentation (wiki pages, ReadMe etc), if applies

CLAassistant commented 3 months ago

All committers have signed the CLA.

raezt commented 3 months ago

add default make for Rev_D

raezt commented 3 months ago

there are some build errors that need handling in the first place, prior to the review. Also, what about REV_B, REV_C? Are those equivalent from the software point of view with REV_D? I'm asking because if that's the case, the software handling for the revisions might be simplified.

Build errors were handled. There are only rev A and rev D. Rev B and rev C do not exist. The default build is now for rev_D.

raezt commented 3 months ago

renamed self_test_PE_upstream
modified the self_test_PE_upstream return
moved "struct no_os_irq_init_param irq_gpio_ip" where the other structures are initialized

raezt commented 3 months ago

squash 2 commits (the second one was fixing the previous one)

raezt commented 3 months ago

optimized the code with conditional jumps (interupt.c).
removed the statement guards where there is only one expression.
changed printf to pr_err.
dropped the extra comment blocks.
memory deallocated in case of error.

raezt commented 3 months ago

squash 2 commits (the first one was implementing just a part of the added functionality)

raezt commented 3 months ago

changed the makefile for revision

raezt commented 3 months ago

REV_A=true changed to REV_A=y in commit message.
deleted line from eof in makefile.
add Functions Definition header comment in inter.c.
unrelated change in self_test.c resolved.