projects: adv7511: src: main.c: Add I2C dev id - Githubissues

analogdevicesinc / no-OS

Software drivers in C for systems without an operating system

http://analogdevicesinc.github.io/no-OS/

Other

871 stars 1.63k forks source link

projects: adv7511: src: main.c: Add I2C dev id #2231

Closed danmois closed 1 week ago

danmois commented 1 week ago

Pull Request Description

Initialize the I2C device id in the adv7511_i2c_init structure.

PR Type

[ ] Bug fix (change that fixes an issue)
[ ] New feature (change that adds new functionality)
[ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

[x] I have followed the Coding style guidelines
[x] I have performed a self-review of the changes
[x] I have commented my code, at least hard-to-understand parts
[x] I have build all projects affected by the changes in this PR
[x] I have tested in hardware affected projects, at the relevant boards
[x] I have signed off all commits from this PR
[x] I have updated the documentation (wiki pages, ReadMe etc), if applies

danmois commented 1 week ago

Also, is the adv7511_extra_i2c_init.device_id = XPAR_AXI_IIC_MAIN_DEVICE_ID; still needed?

This member is also needed since it is used by xil_i2c_init() in xilinx_i2c.c

danmois commented 1 week ago

V2

correct commit body (replace SPI with I2C)
specify reason for initializing device_id in the commit body