Segmentation fault for no_os_uart fix

CAcarADI commented 1 week ago

Pull Request Description

-Added Initialization for no_os_uart_init() function -Added separate GPIO definitions.

PR Type

[X] Bug fix (change that fixes an issue)
[ ] New feature (change that adds new functionality)
[ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

[X] I have followed the Coding style guidelines
[X] I have performed a self-review of the changes
[X] I have commented my code, at least hard-to-understand parts
[X] I have build all projects affected by the changes in this PR
[X] I have tested in hardware affected projects, at the relevant boards
[X] I have signed off all commits from this PR
[X] I have updated the documentation (wiki pages, ReadMe etc), if applies

CLAassistant commented 1 week ago

All committers have signed the CLA.

CiprianRegus commented 1 week ago

The memory allocation is done in the platform specific driver (e.g https://github.com/analogdevicesinc/no-OS/blob/main/drivers/platform/maxim/max32650/maxim_uart.c#L258).

CAcarADI commented 1 week ago

The memory allocation is done in the platform specific driver (e.g https://github.com/analogdevicesinc/no-OS/blob/main/drivers/platform/maxim/max32650/maxim_uart.c#L258).

Thanks for the reply, Ill try to initialize it on the platform driver and update my commit.

CiprianRegus commented 6 days ago

Please squash the 2 commits and remove the changes done to the AD74416H project, as they seem unrelated. When implementing changes suggested by reviewers, you'll have to edit the original commit (git interactive rebase comes in handy for that) instead of creating a new one. Also the commits need a description and have to be signed.

analogdevicesinc / no-OS