search

analogdevicesinc / precision-converters-firmware

Precision Converters Embedded Firmware Repository
https://analogdevicesinc.github.io/precision-converters-firmware/
Apache License 2.0
16 stars 18 forks source link

Build projects using Mbed CLI 1 #43

Closed pamolloy closed 1 year ago

pamolloy commented 1 year ago

The final piece of the #16 puzzle. This builds the projects using the mbed CLI commands. If that is no longer desired then I would suggest removing libraries/*.lib, .mbedignore and libraries/.mbedignore, since they're not used by the no-OS Makefiles.

The mbed CLI commands are used to verify that the Keil Studio Web IDE is able to build the projects. I don't know of a way to test the Keil Studio Web IDE directly using Github Actions.

mphalke commented 1 year ago

The no-os make scripts also for Mbed uses mbed CLI to build the mbed-os library. https://github.com/analogdevicesinc/no-OS/blob/master/tools/scripts/mbed.mk#L93 So I don't see that as an issue here and we don't have to use Mbed CLI to build the project. Another point is, keil studio cloud uses ARMC compiler to build the project and not GCC, so at the end it depends upon compiler. If Mbed CLI script can somehow make use of ARMC compiler, then we can say we are building the projects using both make (gcc) and keil studio cloud (ARMC). I don't think this needs to be taken care now and we can just stick to no-OS make based approach.

mphalke commented 1 year ago

I am not in favor of adding .lib files under separate libs folder. Everything should go into libraries folder. Keil studio IDE can use the .lib files from libraries folder and ignore the submodules.

pamolloy commented 1 year ago

Closing this based on our discussion on Wednesday, but another method should eventually be implemented to verify the *.lib and .mbedignore files in the repository.