dlech commented 9 months ago

Description

Since Python objects will dynamically add an attribute if one does not exist when calling setattr(), we need to check that the attribute actually exists before setting it. Otherwise, tests will pass even if the attribute is not defined in the object being tested.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How has this been tested?

While developing #474, I noticed that tests were passing when I had an obvious mistake. Applying this fix caught the mistake.

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have signed off all commits and they contain "Signed-off by: "
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

github-actions[bot] commented 9 months ago

Unit Test Results

1 249 tests ±0   247 :heavy_check_mark: ±0 5m 12s :stopwatch: +8s       1 suites ±0 1 002 :zzz: ±0       1 files ±0       0 :x: ±0

Results for commit fa0404ff. ± Comparison against base commit 301a5f5c.

:recycle: This comment has been updated with latest results.