analogdevicesinc / pyadi-iio

Python interfaces for ADI hardware with IIO drivers (aka peyote)
https://analogdevicesinc.github.io/pyadi-iio
Other
141 stars 101 forks source link

Rename ad578x driver #523

Closed SaikiranGudla closed 6 months ago

SaikiranGudla commented 8 months ago

Rename ad578x driver, files and other occurances to ad579x

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

SaikiranGudla commented 8 months ago

Is this PR good to be merged, @tfcollins ?

tfcollins commented 7 months ago

What is this being renamed? Does it not support ad5780 devices?

SaikiranGudla commented 7 months ago

Is this PR good to be merged, @tfcollins ?

What is this being renamed? Does it not support ad5780 devices?

It is being renamed to ad579x as it's the flagship part and also to align with no-os, FW and linux drivers. It still supports ad578x, 6x, 9x devices.

SaikiranGudla commented 7 months ago

Is this PR good to be merged, @tfcollins ?

tfcollins commented 6 months ago

@SaikiranGudla please rebase onto main

SaikiranGudla commented 6 months ago

@SaikiranGudla please rebase onto main

Rebased onto main

SaikiranGudla commented 6 months ago

Does this affect https://github.com/analogdevicesinc/pyadi-iio/blob/main/supported_parts.md ? Please update this file as well https://github.com/analogdevicesinc/pyadi-iio/blob/main/test/emu/hardware_map.yml#L450

No, the supported parts will still be the same. Updated hardware_map.yml, renamed xml file.

tfcollins commented 6 months ago

If you can just update the supported_parts.md file we are good

SaikiranGudla commented 6 months ago

If you can just update the supported_parts.md file we are good

The supported_parts.md file already contains all the supported parts (AD5760/80/81/90/91) https://github.com/analogdevicesinc/pyadi-iio/blob/main/supported_parts.md?plain=1#L63

tfcollins commented 6 months ago

@SaikiranGudla as you can see CI is failing. Please add ad579x here https://github.com/analogdevicesinc/pyadi-iio/blob/main/tasks.py#L164