Unit tests launch with ng test always succeed

analogjs / analog

The fullstack meta-framework for Angular. Powered by Vite and Nitro

https://analogjs.org

MIT License

2.53k stars 241 forks source link

Unit tests launch with ng test always succeed #1172

Closed ArnoldM closed 1 month ago

ArnoldM commented 3 months ago

Please provide the environment you discovered this bug in.

Create a new analogJs project and run "ng test"

Which area/package is the issue in?

vitest-angular

Description

The test should create the app in app.component.spec.ts succeeds with expect(app).toBeTruthy() and expect(app).not.toBeTruthy()

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

[ ] Yes
[x] No

brandonroberts commented 1 month ago

The @analogjs/vitest-angular package is the default and recommended package now. The issue should be fixed in the old package, but the new one should be used going forward.