chore: update to Nx 19.5.3 and Angular 18.2.x

analogjs / analog

The fullstack meta-framework for Angular. Powered by Vite and Nitro

https://analogjs.org

MIT License

2.52k stars 240 forks source link

Closed benpsnyder closed 1 week ago

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	68e94c5689801ac2d6921ca92556d01a5c8bcfd7
Latest deploy log	https://app.netlify.com/sites/analog-app/deploys/66e6696c337e7e0008ecfd21
Deploy Preview	https://deploy-preview-1348--analog-app.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	68e94c5689801ac2d6921ca92556d01a5c8bcfd7
Latest deploy log	https://app.netlify.com/sites/analog-docs/deploys/66e6696cfe76cf0008e4ad5c
Deploy Preview	https://deploy-preview-1348--analog-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	68e94c5689801ac2d6921ca92556d01a5c8bcfd7
Latest deploy log	https://app.netlify.com/sites/analog-ng-app/deploys/66e6696c8ae44100089c98b1
Deploy Preview	https://deploy-preview-1348--analog-ng-app.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	68e94c5689801ac2d6921ca92556d01a5c8bcfd7
Latest deploy log	https://app.netlify.com/sites/analog-blog/deploys/66e6696cfb67f90008a300cf
Deploy Preview	https://deploy-preview-1348--analog-blog.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

benpsnyder commented 2 weeks ago

brandonroberts commented 1 week ago

@benpsnyder everything is building correctly on Vercel. I'm wondering why there are so many touched files though? Did the Nx migration do this?

benpsnyder commented 1 week ago

@benpsnyder everything is building correctly on Vercel. I'm wondering why there are so many touched files though? Did the Nx migration do this?

@brandonroberts some notes

I had to remove "outputs": ["{workspaceRoot}/{options.outputPath}"], to get the builds to work and didn't see any negative impact.
regarding apps/docs-app/package.json if memory serves me, I had to update package versions to get docusaurus happily building
NODE_OPTIONS memory had to be increases otherwise builds were failing due to insufficient memory
Change of backticks to single quotes on some files was due to biomejs; I could revert those if you want