search

analogjs / analog

The fullstack meta-framework for Angular. Powered by Vite and Nitro
https://analogjs.org
MIT License
2.61k stars 251 forks source link

fix(vite-plugin-angular): add NODE_ENV check as fallback for production #1432

Closed brandonroberts closed 3 weeks ago

brandonroberts commented 3 weeks ago

PR Checklist

Related to: https://github.com/storybookjs/storybook/issues/22544#issuecomment-2455088246

What is the new behavior?

process.env['NODE_ENV'] === 'production' is used as a fallback check for production mode so the correct flags are set for prod optimizations and tree-shaking.

Does this PR introduce a breaking change?

Other information

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 3 weeks ago

Deploy Preview for analog-ng-app ready!

Name Link
Latest commit 2039e4c79e93a4fcada0c6ba438876314b6a54b2
Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/67290f3b617aaf00089fd5a8
Deploy Preview https://deploy-preview-1432--analog-ng-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for analog-docs ready!

Name Link
Latest commit 2039e4c79e93a4fcada0c6ba438876314b6a54b2
Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/67290f3b3c0b4400084a3583
Deploy Preview https://deploy-preview-1432--analog-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for analog-app ready!

Name Link
Latest commit 2039e4c79e93a4fcada0c6ba438876314b6a54b2
Latest deploy log https://app.netlify.com/sites/analog-app/deploys/67290f3be190f2000834aa20
Deploy Preview https://deploy-preview-1432--analog-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for analog-blog ready!

Name Link
Latest commit 2039e4c79e93a4fcada0c6ba438876314b6a54b2
Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/67290f3b755cd400086a0b2a
Deploy Preview https://deploy-preview-1432--analog-blog.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.