analogjs / analog

The fullstack meta-framework for Angular. Powered by Vite and Nitro
https://analogjs.org
MIT License
2.61k stars 251 forks source link

perf(vite-plugin-angular): speed up tests by reusing compiler #1444

Closed yjaaidi closed 1 week ago

yjaaidi commented 1 week ago

PR Checklist

The current plugin creates a new compiler for each test file, thus slowing down tests.

P.S.: I am willing to add some performance tests but let's discuss the strategy first 😊

What is the new behavior?

This PR speeds up tests considerably (3x to 10x)

Does this PR introduce a breaking change?

Other information

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 week ago

Deploy Preview for analog-blog ready!

Name Link
Latest commit e8082960989e3610941afc2b52f3765927c75790
Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/673c9803a7da37000867c420
Deploy Preview https://deploy-preview-1444--analog-blog.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for analog-docs ready!

Name Link
Latest commit e8082960989e3610941afc2b52f3765927c75790
Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/673c980394dbd10008500fe4
Deploy Preview https://deploy-preview-1444--analog-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for analog-app ready!

Name Link
Latest commit e8082960989e3610941afc2b52f3765927c75790
Latest deploy log https://app.netlify.com/sites/analog-app/deploys/673c9803d677a700081b1f7b
Deploy Preview https://deploy-preview-1444--analog-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yjaaidi commented 1 week ago

https://github.com/analogjs/analog/pull/1443 is an even better alternative.

netlify[bot] commented 1 week ago

Deploy Preview for analog-ng-app ready!

Name Link
Latest commit e8082960989e3610941afc2b52f3765927c75790
Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/673c9803ee4d440008908944
Deploy Preview https://deploy-preview-1444--analog-ng-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brandonroberts commented 1 week ago

Published in 1.9.5-beta.1