search

analogjs / analog

The fullstack meta-framework for Angular. Powered by Vite and Nitro
https://analogjs.org
MIT License
2.61k stars 251 forks source link

mermaid in marddown file not rendered #846

Open DrMabuse23 opened 10 months ago

DrMabuse23 commented 10 months ago

Please provide the environment you discovered this bug in.

node --version v18.18.2

Which area/package is the issue in?

create-analog

Description

I created up a repository for you just do 

npm i
npx nx run analog-app:serve

please see discord discussion

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

d-koppenhagen commented 10 months ago

@DrMabuse23 the referenced repo seems not to be public, or even exist.

have configured to use mermaid as described in the docs?

withMarkdownRenderer({
  loadMermaid: () => import('mermaid'),
});
DrMabuse23 commented 10 months ago

Sorry I changed the Visibility

brandonroberts commented 10 months ago

It is a bug because the MarkdownRouteComponent does not load the necessary mermaid functionality

https://github.com/analogjs/analog/blob/main/packages/content/src/lib/markdown-route.component.ts

The AnalogMarkdownComponent does.

https://github.com/analogjs/analog/blob/main/packages/content/src/lib/markdown.component.ts

rlmestre commented 9 months ago

Is the separate route component necessary at all? They are the same except the mermaid functionality 👀