analogwp / analogwp-templates

Style Kits for Elementor adds a number of intuitive styling controls in the Elementor editor that allow you to apply styles globally or per page.
https://analogwp.com
27 stars 7 forks source link

Ensure translations work fine #330

Closed mauryaratan closed 4 years ago

mauryaratan commented 4 years ago
mauryaratan commented 4 years ago

@lushkant what's the status on this?

lushkant commented 4 years ago

Our current build produces ang.js pot which is not right and is made for the source files not the actual one on which we use wp_set_script_translations and that is app.js

btw Ram you can see some of the stuff I pushed in feature/330_fix_translations > https://github.com/mauryaratan/analogwp-templates/blob/feature/330_fix_translation/

it also includes some changes in webpack config to not loose i18n methods in the app.js but it essentially increases the resulting file size, since I also had to turn off mangle for similar reasons.