search

analogwp / analogwp-templates

Style Kits for Elementor adds a number of intuitive styling controls in the Elementor editor that allow you to apply styles globally or per page.
https://analogwp.com
27 stars 7 forks source link

Elementor migration from version 2.9 to 3 #392

Closed gvgvgvijayan closed 4 years ago

gvgvgvijayan commented 4 years ago

Removed wrapper which we are using:

elementor-row: class-typography.php Line:439

Class prefix truncated:

Elementor truncated CSS class prefix from .elementor- to .e- applicable for the newer widgets, controls, or system elements but not pre-existing one. If you are developing extensions that manipulate existing system elements, controls or widgets, and used the .elementor- prefix before – we recommend you to follow this guideline and start using .e- instead in your new developments.

Browser support:

No IE support.

gvgvgvijayan commented 4 years ago

Checked the following test cases:

  1. Check loading of style kit library - Templates, Style Kits, Blocks tab
  2. Check filters in Templates tab
  3. Check filters in Blocks tab
  4. check collections card in Templates tab
  5. check collections card in Blocks tab
  6. check "BACK TO KITS" in template list of a template collection
  7. Check "BACK TO ALL BLOCKS" in block list of a block collection
  8. Click "Preview" action in template card and check preview iframe DOM loaded
  9. Click "Preview" action in style kits card and check preview iframe DOM loaded
  10. Check "Go Pro" redirection in Templates, Style Kits and Blocks
  11. Check import templates to library through import button in template card
  12. Check import templates to page through import button in template card
  13. Check import style kit to "Theme Style Kits" submenu page through import button in style kit card
  14. Check import existing style kit to "Theme Style Kits" submenu page through import button and added new name in popup input of style kit card
  15. Check import blocks through clicking import button in block card
  16. Check in pages table (wp-admin/edit.php?post_type=page) able to apply global style kit for a page
  17. Check able to edit with elementor for the page generated through analog template import
  18. Check "Edit Theme Style Kit" by modify page properties in elementor kit panel controls
  19. Check able to import widget into the elementor page and modify it's properties in control panel
  20. Check all theme style SK controls by modifying values
gvgvgvijayan commented 4 years ago

Verified the elementor master branch still it hasn't removed class elementor-row for details please check the attached screenshot. elementor_v3_elementor-row

mauryaratan commented 4 years ago

@gvgvgvijayan Can you please double-check this on the beta they attached? It's possible that the branch we used wouldn't have that part of code merged?

gvgvgvijayan commented 4 years ago

Issues

Issue 1:

Visual Diff: sk_controls_missing

gvgvgvijayan commented 4 years ago

All test cases passed in WP: 5.4.2 Elementor V3 Beta

mauryaratan commented 4 years ago

@gvgvgvijayan is there anything in this issue that still needs to be done? If yes, let's create a separate issue with the task list and close this.

gvgvgvijayan commented 4 years ago

@mauryaratan ok I will close this. Future issues will be in its own ticket.