search

analogwp / analogwp-templates

Style Kits for Elementor adds a number of intuitive styling controls in the Elementor editor that allow you to apply styles globally or per page.
https://analogwp.com
27 stars 7 forks source link

Get_plugins() call conflicts with other plugins having similar calls #396

Closed gvgvgvijayan closed 4 years ago

gvgvgvijayan commented 4 years ago

https://github.com/analogwp/analogwp-templates/issues/394

lushkant commented 4 years ago

Hey @gvgvgvijayan As Ram said - https://github.com/analogwp/analogwp-templates/pull/397#issuecomment-661725319

We cannot use active_plugins hook to check for plugins because we need to check if the plugin is installed first then do activate messages as well.

In the upcoming WP 5.5, there is a REST endpoint which gives us an option to check installed plugins, we can utilize this here as a resolve for our current situation.

image

Take a look here for more info on this - https://make.wordpress.org/core/2020/07/16/new-and-modified-rest-api-endpoints-in-wordpress-5-5/

Let me know if you have any questions 😃

gvgvgvijayan commented 4 years ago

Hi @lushkant

Rest API will not be a backward compatible one but we can use this in the near future.

lushkant commented 4 years ago

@gvgvgvijayan I've left some comments in your last commit, please go through them when you can 😄