Making the tests suite DRY

analyseether / ether_sql

A python library to push ethereum blockchain data into an sql database.

http://ether-sql.readthedocs.io

Apache License 2.0

69 stars 22 forks source link

Making the tests suite DRY #21

Closed ankitchiplunkar closed 6 years ago

ankitchiplunkar commented 6 years ago

Is your feature request related to a problem? Please describe. The tests suite contains tests for two different nodes Infura and Parity, there are several pieces of code that repeat themselves. We need to put these pieces of repeated code in the tests/fixtures and reuse them in individual node tests

Describe the solution you'd like I would prefer the tests to be written more with https://github.com/ethereum/web3.py/tree/master/tests philosophy.

ankitchiplunkar commented 6 years ago