watchdog version up and add minimal template using r-minimal image

analythium / openfaas-rstats-templates

OpenFaaS templates for R

MIT License

19 stars 1 forks source link

watchdog version up and add minimal template using r-minimal image #13

Closed mrchypark closed 4 years ago

mrchypark commented 4 years ago

update of-watchdog 0.7.2 to 0.7.6 update watchdog 0.18.1 to 0.18.10 add minimal version template based on alpine linux

psolymos commented 4 years ago

Hi @mrchypark I reviewed you PR a few days ago but I have been traveling since then. Here is wat I think:

Upgrading to newer of-watchdog version makes sense.
I really like the minimal template, but it might make sense to make a separate PR for that one and
leave the RestRserve template for later: there is potential but it is not working yet.

mrchypark commented 4 years ago

I agree. I'm not good at PR.

I'm trying to separate PR later. Thank you for response.

psolymos commented 4 years ago

I appreciate your work, and I am sure you'll get better at PRs! Here is what I would suggest: focus on the 1st 2 parts of my previous comments (1: updating of-watchdog versions, 2: r-minimal template).

I am also working on a CONTRIBUTING guide that'll make things easier next time.

Thanks.

mrchypark commented 4 years ago

I add 2 PR. ;) Thank you for your guide.

psolymos commented 4 years ago

Thanks. See PRs #15 and #16