analyticalmonk / Rperform

:bar_chart: R package for tracking performance metrics across git versions and branches.
https://analyticalmonk.github.io/Rperform
GNU General Public License v3.0
65 stars 9 forks source link

Suggestion of passing fail commit when using compare function #38

Open RoverVan opened 7 years ago

RoverVan commented 7 years ago

Hi @analyticalmonk , as @tdhock suggests, there is another advice for Rperform.

When i use plot_branchmetrics() function to compare the performance of two branch, as the doc of this function, it will run all the commit from branch1's latest commit until the first commit common to 'branch2'. However, some of the commits are depend on the other commit. It means that it cannot be compiled independently. In this way, the compile error occurs and the Rperform will stop with none result.

We believe that it would be better to pass this bad commit (Maybe show "error" in the result) until all commit are run. In my way, i use git rebase to avoid the above question by merging some commits.

Here are two different versions of optimization branch. I think they will help in test the program.

optimization branch with all commit optimization branch with three commit (after rebase)

Additionally, to install optimization branch, we have to put the openblas into system share library.

First step is compile openblas and we can get the dynamic-link library (libopenblas.dll.a, libopenblas.dll in windows or libopenblas.dylib in MacOS or libopenblas.so in Linux/Ubuntu)

Second step is put them into the folder below /usr/lib/openblas-base/ this path is for Linux or MacOS or Ubuntu C:\WINDOWS\system32\ this path is for windows

I am available if you need more info or any help in iregnet.