search

analyticalmonk / Rperform

:bar_chart: R package for tracking performance metrics across git versions and branches.
https://analyticalmonk.github.io/Rperform
GNU General Public License v3.0
65 stars 9 forks source link

Update dependencies and fix related issues, create Github Workflow for Rperform #47

Closed EngineerDanny closed 2 years ago

EngineerDanny commented 2 years ago

This PR fixes most of the issues raised.

  1. Indentation inconsistency in the R files have been fixed by using R studio's built-in indentation. (1)
  2. Various binary files and directories have been added to the .gitignore file. (2)
  3. animint package has been updated to animint2 which comes with improved features and better syntax.
  4. git2r package has also been updated to support the latest features and improvements git2r (>= 0.30.1)
  5. Named reference approach has been adopted to reference list members by names instead of numeric indexes. (3)
  6. A Github CI Worflow has been created for setting up Rperform and running R CMD Check by using r-lib/actions

R CMD Check Runs successfully ✅

This PR closes #44 and fixes #45

EngineerDanny commented 2 years ago

Sure. I will update that and submit another PR.

analyticalmonk commented 2 years ago

Amazing work @EngineerDanny! :tada: cc: @tdhock

EngineerDanny commented 2 years ago

Great Akash

On Mon, Jun 27, 2022 at 5:41 PM Akash Tandon @.***> wrote:

@.**** approved this pull request.

The changes look good.

We should also update the README to incorporate your findings regarding testing the stringr package with Rperform. We can do that in a separate PR.

— Reply to this email directly, view it on GitHub https://github.com/analyticalmonk/Rperform/pull/47#pullrequestreview-1020556825, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJZRXO57FYLN5K4LPF4QK3VRHRTFANCNFSM5ZZXRFZQ . You are receiving this because you were assigned.Message ID: @.***>