analyticalmonk / Rperform

:bar_chart: R package for tracking performance metrics across git versions and branches.
https://analyticalmonk.github.io/Rperform
GNU General Public License v3.0
65 stars 9 forks source link

Update README #48

Closed analyticalmonk closed 2 years ago

analyticalmonk commented 2 years ago
EngineerDanny commented 2 years ago

I am not quite sure though if the Github Workflow R CMD Check should be placed in the README.md instead of the Travis CI Build. What are your suggestions on this @analyticalmonk ?

analyticalmonk commented 2 years ago

I am not quite sure though if the Github Workflow R CMD Check should be placed in the README.md instead of the Travis CI Build

@EngineerDanny Sorry but I did not understand your question. Why are you considering placing the Github workflow piece in the README?

EngineerDanny commented 2 years ago

The result badge could be there to show the users whether the R CMD Check test is passing or failing. It is required that R CMD Check must pass before a package can be published.

EngineerDanny commented 2 years ago

For instance binsegRcpp, stringr all have the R CMD Check result badge. Hope you understand my point @analyticalmonk

analyticalmonk commented 2 years ago

@EngineerDanny Yes, we should add the appropriate badge. I have also updated the issue to reflect that as a task.

EngineerDanny commented 2 years ago

Great