search

anametologin / krohnkite

A dynamic tiling extension for KWin
MIT License
289 stars 14 forks source link

Makefile `clean` target removes file tracked by git (`package.json`) #25

Closed suhail-singh closed 3 months ago

suhail-singh commented 3 months ago

Symptom In the git repository, package.json is being tracked. However, when one runs the make clean command it gets deleted. One of these behaviours seems unintended. The little that I know about Node development leads me to believe the Makefile has a bug, but I'm not certain.

How to Reproduce

  1. Clone the git repository
  2. Invoke make clean
  3. See error

Expected behavior clean target should not remove files tracked by git.

Environment

Notes N/A

anametologin commented 3 months ago

Fixed.

suhail-singh commented 3 months ago

Taking a closer look, the Makefile also references a res/package.json. Could it be that the Makefile clean target was doing the right thing, but the issue was that the toplevel package.json ought not to have been tracked in git to begin with?

If not, could you please elaborate on the differences between toplevel package.json and the one under res/?

anametologin commented 3 months ago

res/package.json - joined with the main one and removed. Makefile - changed