search

anametologin / krohnkite

A dynamic tiling extension for KWin
MIT License
95 stars 7 forks source link

Typo in shortcuts declaration #9

Closed WNacci closed 1 month ago

WNacci commented 1 month ago

Symptom There is a single-character typo in the shortcuts.qml file, resulting in the Shrinkheight command not working.

(Line 124 in res/shortcuts.qml)

Additionally, it seems that shrinkheight and growheight might be inverted?

How to Reproduce

  1. Upon install via the kwin scripts manager, the incorrect shortcut is added

Environment

Notes Thank you for enabling support for Krohnkite in KDE 6!

anametologin commented 1 month ago

I fixed the typo, but keep in mind that the old one does not disappear. Delete all unused KWin shortcuts: qdbus org.kde.kglobalaccel /component/kwin org.kde.kglobalaccel.Component.cleanUp I will write this in readme.md.

Additionally, it seems that shrinkheight and growheight might be inverted?

It's relatively. Original author meant the south. You mean the North. I do not want to touch the shortcuts because old shortcuts do not disappear itself.