anancarv / python-artifactory

Typed interactions with the Jfrog Artifactory REST API
MIT License
55 stars 50 forks source link

Feature/add terraform support #126

Closed Frantche closed 1 year ago

Frantche commented 1 year ago

Description

This PR aims to add terraform repository to pyartifactory.

In the mean time I have issueswith github action due to python3.6 being EOL. So I updated the Github action/Code to be compatible from 3.8 to 3.10.

Please delete options that are not relevant.

How has it been tested ?

The code has been tested with github action and locally

Checklist:

kwening commented 1 year ago

Would it be possible to provide Terrafrom support, when only adding them to the PackageTypeEnum?
I'd happily provide a PullRequest that only contains these changes.

anancarv commented 1 year ago

Would it be possible to provide Terrafrom support, when only adding them to the PackageTypeEnum? I'd happily provide a PullRequest that only contains these changes.

@kwening yes you can add terraform to the PackageTypeEnum. That is the only change needed for providing Terraform support.

anancarv commented 1 year ago

@Frantche I'm closing this PR because it's a duplicate of #137 which has been merged

Frantche commented 1 year ago

Thanks @anancarv.