feat: Support setting CA certificate

vjda commented 11 months ago

Description

Support setting a custom CA certificate to validate SSL termination.

This change takes advantage of the ability of the request library to support setting custom CA certificates by passing the key verify=/path/to/ca.pem as an argument.

See requests.request for additional information.

Type of change

[x] New feature (non-breaking change which adds functionality)

How has it been tested ?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[x] New connection by providing a custom CA certificate path in key verify=/path/to/ca.pem
[x] New connection by disabling SSL verification with verify=False
[x] New connection by enabling SSL verification with verify=True

Checklist

[x] My PR is ready for prime time! Otherwise use the "Draft PR" feature
[x] All commits have a correct title
[x] Readme has been updated
[x] Quality tests are green (see Codacy)
[x] Automated tests are green (see pipeline)

vjda commented 11 months ago

You'll also need to add typing here

Fixed

vjda commented 11 months ago

It seems that test matrix stages are failing in the Github workflow. However I ran the tests on my laptop and they worked OK.

Checking the commit history I think #144 broke the code coverage reporting .

2023-10-09 17:30:07.714Z error [CodacyCoverageReporter] Invalid configuration: Empty argument for --project-token  - (CodacyCoverageReporter.scala:25)

Not quite sure how to fix it but happy to help if you want 😀

anancarv commented 11 months ago

It seems that test matrix stages are failing in the Github workflow. However I ran the tests on my laptop and they worked OK.

Checking the commit history I think #144 broke the code coverage reporting .
2023-10-09 17:30:07.714Z error [CodacyCoverageReporter] Invalid configuration: Empty argument for --project-token  - (CodacyCoverageReporter.scala:25)
Not quite sure how to fix it but happy to help if you want 😀

Don't worry about that. It's because you don't have the codacy token set on your repo.

anancarv / python-artifactory