anancarv / python-artifactory

Typed interactions with the Jfrog Artifactory REST API
MIT License
60 stars 51 forks source link

Pass the artifacts checksums in the headers of the deploy request #199

Open aslheyrr opened 1 month ago

aslheyrr commented 1 month ago

Description

Artifactory UI shows a warning message in the uploaded artifacts when artifact checksums aren't provided, therefore we would like to push a checksum of binaries being deployed.

Pushing checksums doesn't seem to be a well documented feature in the JFrog documentation, however here is brief reference to it https://jfrog.com/help/r/why-am-i-getting-client-did-not-publish-a-checksum-value-for-npm-packages/why-am-i-getting-client-did-not-publish-a-checksum-value...-for-npm-packages

Type of change

Please delete options that are not relevant.

How has it been tested ?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Checklist:

aslheyrr commented 1 month ago

Hi @anancarv, could you please take a look at this? it seems like the token for codacy is missing

anancarv commented 1 month ago

Hi @anancarv, could you please take a look at this? it seems like the token for codacy is missing

Hey @aslheyrr, sure I will take a look at the MR this week. Don't worry about codacy

aslheyrr commented 2 weeks ago

Hi @anancarv just a friendly reminder that this MR is awaiting review

aslheyrr commented 4 days ago

Hi @anancarv, did you see my comments? I'd like to get your feedback so we can move forward with this feature

aslheyrr commented 3 days ago

hey @anancarv I made some code changes in this branch, could you review them?