anancarv / python-artifactory

Typed interactions with the Jfrog Artifactory REST API
MIT License
60 stars 51 forks source link

Fix errors in local path when downloading artifacts on Windows #73

Closed Fronkan closed 3 years ago

Fronkan commented 3 years ago

Description

This PR aims to fix an issue where artifacts downloaded on Windows got the wrong local path. This was caused by a split on "/", which broke when running on Windows, which uses "\" for separation.

Type of change

There is a risk for this to be breaking for users running on Windows as it changes where downloaded artifacts are stored. However, it will now be in line with how it is expected to work.

How has it been tested?

Tested using the existing unit-test suite, which had a failing test on Windows.

Checklist:

Fronkan commented 3 years ago

Looking at the contribution guide I couldn't find how to verify using Codacy, is this done automatically on the creation of PR?

I also couldn't find any guidelines on the commit titles. I hope they follow your standard, otherwise please tell me and I will fix it.

anancarv commented 3 years ago

Hi @Fronkan , Thaks for your contribution. I think that it can be a good fix for the issue #70 we faced a while ago. I'll have a look at your PR and send my review ASAP. You commit message is OK and you can find Codacy results right here: https://app.codacy.com/manual/Ananias/python-artifactory/pullRequest?prid=6596935