anancarv / python-artifactory

Typed interactions with the Jfrog Artifactory REST API
MIT License
55 stars 50 forks source link

feat: add build and releaseBundle to PermissionV2 #90

Closed anancarv closed 3 years ago

anancarv commented 3 years ago

Description

The PermissionV2 feature is not complete. Indeed, the objects build and releaseBundle are missing and if you update an existing permission which has both "repo" and "build" but don't set one or the other, the corresponding sub-permission is removed.

Type of change

Please delete options that are not relevant.

Checklist:

thenewnano commented 3 years ago

I just was looking into what was needed to be added, I still lack a testing server with builds, thank you for completing the V2 permissions, Did a quick look at the changes, and they look good, will check it out and test it a bit

thenewnano commented 3 years ago

Pulled the branch and checked it locally, looks good, better get this out so others don't start using it and messing up permissions.