search

anand0xff / ImPlaneIA

Tools for fitting (image plane fringes), calibrating, and analyzing NRM data across multiple instruments and modes
BSD 3-Clause "New" or "Revised" License
7 stars 4 forks source link

Made -m argument optional (default = 0 for polychromatic), 1 for monochromatic #2

Closed dthatte closed 4 years ago

anand0xff commented 4 years ago

It might be cleaner to make no arguments for polychromatic, -m for monochromatic. I can do this later if you prefer - I want a cleaner code structure with the 'monochromatization' of a filter as something in a function rather than in the driver (in the driver it's not accessible to programs that might use this script by importing it).

If I do this I'd just look for "-m" or "--monochromatic" in the list that is sys.argv, and set the internal variable monchromatic to True or False.

dthatte commented 4 years ago

It makes sense to have 'monochromatization' of a filter in a function.

anand0xff commented 4 years ago

I’ll do that and change the call. I can still use argparse

On Tue, Feb 4, 2020 at 2:30 PM dthatte notifications@github.com wrote:

It makes sense to have 'monochromatization' of a filter in a function.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/anand0xff/ImPlaneIA/pull/2?email_source=notifications&email_token=AAZ2QCATHQ2IKUGBS4KIDJDRBG64PA5CNFSM4KPLFT52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKY4NIQ#issuecomment-582076066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZ2QCDLXITUX5AC4ZRRVV3RBG64PANCNFSM4KPLFT5Q .