Hammer, Hanging Man, and Shooting Star Corrections

anandanand84 / technicalindicators

A javascript technical indicators written in typescript with pattern recognition right in the browser

MIT License

2.15k stars 557 forks source link

Hammer, Hanging Man, and Shooting Star Corrections #145

Closed marcus-n3rd closed 6 years ago

marcus-n3rd commented 6 years ago

Added hammer, hanging man, and shooting star patterns to bearish and bullish indicators.
- Bearish:
- Bearish Hammer
- Bearish Inverted Hammer
- Hanging Man
- Hanging Man (Unconfirmed)
- Shooting Star
- Shooting Star (Unconfirmed)
- Bullish:
- Bullish Hammer
- Bullish Inverted Hammer
- Hammer Pattern
- Hammer Pattern (Unconfirmed)
Added indicators to src/index.ts
Updated README.md regarding how to add new indicators

marcus-n3rd commented 6 years ago

Also, @anandanand84 , I noticed that the new indicators are not generating *.js.map files. I have tried all the various build scripts but to no avail. Do you have any clarity on how these should be generated?

anandanand84 commented 6 years ago

@marcus-n3rd It is because the source maps are disabled in the typescript config.

https://github.com/anandanand84/technicalindicators/blob/master/tsconfig.json#L20

Do you require it to be enabled? It didn't work any way since it there another mangling of the generated file so you need multiple depth of source maps on the browser.

marcus-n3rd commented 6 years ago

I don't require it, I just noticed the discrepancy and was curious if it was really important.