anandanand84 / technicalindicators

A javascript technical indicators written in typescript with pattern recognition right in the browser
MIT License
2.18k stars 563 forks source link

bullishharami fails with sample data #159

Open temp3l opened 5 years ago

temp3l commented 5 years ago

var bullishharami =require('technicalindicators').bullishharami;

var input = { open: [20.12, 22,13], high: [23.82,22.76], close: [23.50,21.70], low: [19.88,21.31], }

var result = bullishharami(input); console.log('Is Bullish Harami Pattern? :' +result);

sivaraj-v commented 5 years ago

var input = { open: [23.5, 21.7], high: [23.82, 22.76], close: [20.12, 22.13], low: [19.88, 21.31] };

Logic was correct, only the sample data given in the example was wrong, use the above and check.

callmekatootie commented 4 years ago

@sivaraj-v Your input gives false for Bullish Harami using this library, but in my opinion, it should be true. Your inputs indeed follow the pattern of Bullish Harami. I believe there's a bug here with the library