search

anandanand84 / technicalindicators

A javascript technical indicators written in typescript with pattern recognition right in the browser
MIT License
2.14k stars 557 forks source link

Add CrossUp, CrossDown and CrossOver indicator #205

Closed cwouter closed 4 years ago

cwouter commented 4 years ago

This indicator returns true or false if one line crosses another line. In case the previous value of line A equals to line B the indicator will look back until it can find a (in)valid cross and returns true/false accordingly.

Later on i'll add cross down and full cross indicator.

anandanand84 commented 4 years ago

Thankyou I'll try to get this merged tonight

cwouter commented 4 years ago

Thx for the quick response. Should I add CrossDown and CrossOver in a separate PR? I can add both indicators tonight.

anandanand84 commented 4 years ago

you can add it in the same

cwouter commented 4 years ago

I've added the CrossDown and CrossOver indicators. Is the build script still up-to-date? Because on my computer it outputs: 

dts-bundle version 0.7.3
Export TypeScript .d.ts files as an external module definition

sed: 1: "declarations/generated. ...": extra characters at the end of d command
sed: 1: "declarations/generated. ...": extra characters at the end of d command
cwouter commented 4 years ago

@anandanand84 , would you be able to merge this in the next few days? Or can I help you to speed up the merging process? thx

anandanand84 commented 4 years ago

did you change anything in the tests, I am not able to run all the tests, only crossover tests are being run?

anandanand84 commented 4 years ago

I've added the CrossDown and CrossOver indicators. Is the build script still up-to-date? Because on my computer it outputs:

dts-bundle version 0.7.3
Export TypeScript .d.ts files as an external module definition

sed: 1: "declarations/generated. ...": extra characters at the end of d command
sed: 1: "declarations/generated. ...": extra characters at the end of d command

This works only in linux, did you try in mac?

anandanand84 commented 4 years ago

v3.1.0 published with changes