PPP can't work on atm128-based platforms

[GoogleCodeExporter]

What steps will reproduce the problem?

1. apps that use ppp protocol such as 'tos/lib/ppp/tests/Ipv6' can't compile on 
atm128-based platforms(mica-serial,iris), due to the lack of 
AlarmMilli32C/CounterMilli32C/PlatformLedC/avr_stdio.h.
2.  On avr-based platforms, the mote resets when printf() is called, because 
the putchar() function in PppPrintfP only works for msp430.

What version of the product are you using? On what operating system?

tinyos-main svn r5536, IRIS platform, Linux

Please provide any additional information below.

I attached the patch which makes ppp works on IRIS as I tested, hope to solve 
the problem.

Original issue reported on code.google.com by qy.n...@gmail.com on 8 Apr 2011 at 10:09

Attachments:

• ppp-atm128.patch

[GoogleCodeExporter]

Original comment by philip.l...@gmail.com on 17 Apr 2011 at 12:34

[GoogleCodeExporter]

I'm ok with the changes to PPP proper (viz., the init method), but would prefer 
that whoever's responsible for mica be the one who determines whether to add 
PlatformLed components to that platform.  That can proceed without requiring 
anything in ppp.

I'll look into the printf stuff but don't believe things like avr_studio.h 
should be cloned into lib/ppp.  It may be necessary to add 
-I$(TOSDIR)/lib/printf to the Makefiles.

Original comment by pabi...@gmail.com on 17 Apr 2011 at 1:04

• Changed state: Accepted

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I've extracted the mica changes, and submitted those for somebody else to 
review as ticket 32.

I've refactored the printf infrastructure and provided a solution that seems to 
isolate platform-specific material to a single component in lib/printf.  That's 
submitted for review as ticket 33.  (It is possible that changes to that 
infrastructure will be required as I am unable to test it on the mica platform.)

Integration of those two patches should resolve this ticket.

Original comment by pabi...@gmail.com on 17 Apr 2011 at 11:19

[GoogleCodeExporter]

With completion of issue 33, I'm going to call this issue fixed.  Actual 
completion should depend only on issue 32.

Original comment by pabi...@gmail.com on 15 May 2011 at 3:52

• Changed state: Fixed