search

anandsiddharth / laravel-paytm-wallet

Integrate paytm wallet in your laravel application easily with this package. This package uses official Paytm PHP SDK's.
MIT License
92 stars 40 forks source link

fixes issue where successful payments throwed invalid checksum error #39

Closed fawzanm closed 4 years ago

anandsiddharth commented 4 years ago

I won't recommend this change for README.md since it doesn't make sense this package follows the structure of laravel's socialite package. Please create a pull request only for lib/encdec_paytm.php

Thanks,

fawzanm commented 4 years ago

I still believe that the configurations should be loaded from the .env file. Below is a snippet I extracted from the socialite documentation. It makes more sense to extract the configs to the `.env1 file because we have multiple environments ion the paytm sdk itself.

'github' => [ 'client_id' => env('GITHUB_CLIENT_ID'), 'client_secret' => env('GITHUB_CLIENT_SECRET'), 'redirect' => 'http://your-callback-url', ],

anandsiddharth commented 4 years ago

Okay! I think merging this should not break the existing config managed by devs currently using it.