Closed sebastienbarre closed 9 years ago
This looks great, @sebastienbarre.
Thanks for anticipating the API issue in stream
-- I'd say let's go for the second approach you suggested, stream(options, filename)
, since that would stand up more flexibly to future additive changes.
Will do. I assume you are following semver, so I'll be bumping the version to 2.0.0 to reflect the breaking change, ok?
Yep, agreed this makes it 2.0.0.
Heh I managed to change the README out from under you here, hence the merge conflict. Should be an easy rebase.
All done (I think). Sorry, for the last empty merge commit, this always confuses me.
:+1: Looks great, thanks again @sebastienbarre
Thanks. FYI, quick heads up, I've another quick PR coming up for later today, to help with this one, related to #24
Per discussion in #21, add array of ignoring rules, i.e.:
postcss(doiuse(opts)).process(css)
, whereopts
is:A test was added as well, for the PostCSS plugin.
However, neither
stream.js
orcli.js
were updated. The issue here is that it would likely break the current API, a decision I'd rather you make. Right now, the stream signature is:It would have to be updated to support the
ignore
option (i.e. the array of features to ignore). Either:or:
where
options
would have thebrowsers
andignore
keys.Since
cli.js
usesstream.js
, it would have to be updated as well, from:to:
or:
What do you think?