search

anandthakker / doiuse

:bomb: Lint CSS for browser support against caniuse database.
MIT License
1.24k stars 51 forks source link

Ignore a file based on name #29

Closed SevereOverfl0w closed 8 years ago

SevereOverfl0w commented 8 years ago

Would it be possible to ask doiuse to ignore a file based on name? I have Normalize.css being imported via postcss-import, and as it has a lot of browser-specific fixes in there, it's upsetting doiuse.

I have seen that you've slowed down on development, and would be happy to open a PR if you think it's relatively feasible within the codebase.

anandthakker commented 8 years ago

@SevereOverfl0w Hmm -- well, I'm certainly open to it, although if imports are happening before doiuse gets to the CSS, it might be hard to know exactly what came from each file.

SevereOverfl0w commented 8 years ago

Doiuse is picking up the filename, I'm not entirely sure how though! But its definitely correct.

I'll have a go soon! On 8 Nov 2015 2:00 am, "Anand Thakker" notifications@github.com wrote:

@SevereOverfl0w https://github.com/SevereOverfl0w Hmm -- well, I'm certainly open to it, although if imports are happening before doiuse gets to the CSS, it might be hard to know exactly what came from each file.

— Reply to this email directly or view it on GitHub https://github.com/anandthakker/doiuse/issues/29#issuecomment-154770181.

SevereOverfl0w commented 8 years ago

doiuse is picking up the filename, as a node's source has a "file" attribute, which is the original file the line comes from.

Currently testing this locally.

anandthakker commented 8 years ago

Ah, right. Happy to take a PR on it--otherwise, I'd definitely like to add it, but it might take a little while before I'll have time..

On Mon, Nov 9, 2015 at 6:35 AM Dominic Monroe notifications@github.com wrote:

doiuse is picking up the filename, as a node's source has a "file" attribute, which is the original file the line comes from.

— Reply to this email directly or view it on GitHub https://github.com/anandthakker/doiuse/issues/29#issuecomment-155037035.

SevereOverfl0w commented 8 years ago

Yep, it should be a fairly simple addition. I'll pull in minimatch, and match it against the path. I'll find some time in the next couple days to add it.

anandthakker commented 8 years ago

:+1:

On Mon, Nov 9, 2015 at 8:57 AM Dominic Monroe notifications@github.com wrote:

Yep, it should be a fairly simple addition. I'll pull in minimatch, and match it against the path. I'll find some time in the next couple days to add it.

— Reply to this email directly or view it on GitHub https://github.com/anandthakker/doiuse/issues/29#issuecomment-155068885.

anandthakker commented 8 years ago

Closed by #30