search

anandthakker / doiuse

:bomb: Lint CSS for browser support against caniuse database.
MIT License
1.24k stars 51 forks source link

Upgrade browserslist and caniuse #85

Closed pkuczynski closed 6 years ago

pkuczynski commented 6 years ago

Upgraded packages:

    "browserslist": "^3.1.1",
    "caniuse-lite": "^1.0.30000810",

Allows to specify in browsers new dead option https://github.com/ai/browserslist/blob/master/CHANGELOG.md#30

Fixes #84

ismay commented 6 years ago

Duplicate of #84, but I'm all in favor of these changes :)

pkuczynski commented 6 years ago

Not really. #84 has older deps and bring in some other changes :) However, both would fix my issue :) Do you think anybody will merge them in? There is quite a few PR piled in the queue...

ismay commented 6 years ago

Not really. #84 has older deps and bring in some other changes

There's a caret in front of the version numbers, so users will install the latest minor/patch version anyway. So it doesn't matter if the listed version in package.json is older.

Do you think anybody will merge them in? There is quite a few PR piled in the queue...

They're looking for a maintainer atm actually. So it might be a while, but I don't know if you would like a shot at maintaining this? I'm sure they'd be open to it.

pkuczynski commented 6 years ago

Sure. I already maintain some other open source projects, so one would not make a big difference ;) Who should I talk to about it?

ismay commented 6 years ago

Great! @ai has credentials, he’s the one to talk to if I’m not mistaken

ai commented 6 years ago

@pkuczynski so you want to maintain this project and want a access to GitHub and npm?

pkuczynski commented 6 years ago

Sure. It's pretty useful I think. Especially for the project, I am working on currently. How can we organize this?

ai commented 6 years ago

@pkuczynski I need your npm login

ai commented 6 years ago

@ismamz I don’t have access to GitHub repo :(. Can you add him to admins?

ismay commented 6 years ago

@ai Ah damn, neither do I. I removed myself from the group after ‘stepping down’ as a maintainer, so I no longer have any rights. I thought you still had them

pkuczynski commented 6 years ago

@ai my npm login is pkuczynski

ai commented 6 years ago

@ismay removing yourself before finding next maintainer is not the best way ;). At least we could have a big security issue which must be fixed fast.

I wrote to origin author @anandthakker

pkuczynski commented 6 years ago

Yeah, that's what I figured out looking at contributors

ismay commented 6 years ago

@ai Yeah you’re right, I didn’t think of that at the time

anandthakker commented 6 years ago

@pkuczynski added you to the repo and NPM. 🙏 thanks for agreeing to step in!

pkuczynski commented 6 years ago

Looks good! Thanks. Let's see how it goes :)