search

anandts88 / ember-validator

Perform Ember Object Validation
MIT License
5 stars 6 forks source link

Allow addon to be used as a nested addon #14

Closed jbailey4 closed 7 years ago

jbailey4 commented 7 years ago

The app argument in the included hook varies based on whether the addon is being used by another addon/engine (nested) or being consumed by an application. This PR attempts to solve all the scenarios in lieu of a better, public api.

See https://github.com/ember-cli/ember-cli/issues/3718

anandts88 commented 7 years ago

@jbailey4 Travis CI build is getting failed. Please look into that, otherwise this is ok for me. I will merge once the checks are resolved.

jbailey4 commented 7 years ago

@anandts88 looks like ember-beta is failing, not sure why. I'll try to look into this today.

jbailey4 commented 7 years ago

@anandts88 Closing this PR, superseded by https://github.com/anandts88/ember-validator/pull/15