search

anandts88 / ember-validator

Perform Ember Object Validation
MIT License
5 stars 6 forks source link

allows addon to be nested and updates ember-cli version #15

Closed jbailey4 closed 7 years ago

jbailey4 commented 7 years ago

The app argument in the included hook varies based on whether the addon is being used by another addon/engine (nested) or being consumed by an application. This PR attempts to solve all the scenarios in lieu of a better, public api.

See https://github.com/ember-cli/ember-cli/issues/3718

Also, updates ember-cli version.

jbailey4 commented 7 years ago

@anandts88 updating ember-cli seemed to fix the broken test that occurred in #14 . Take a look and make sure I/ember-cli didn't inadvertently overwrite a file.

anandts88 commented 7 years ago

👍

jbailey4 commented 7 years ago

@anandts88 Thanks. Can we cut a new minor release for this

anandts88 commented 7 years ago

@jbailey4 Thanks for the support. 1.3.7 released.