search

anantab / serverless-plugin-ifelse

A Serverless Plugin to write If Else conditions in serverless YAML file
69 stars 19 forks source link

add support for array #34

Open alichherawalla opened 2 years ago

alichherawalla commented 2 years ago

Hi,

Thank you for this amazing library. It has truly made my life much simpler.

Currently, if I exclude an array element, it is replaced with null. For a certain use case my Cloudformation template breaks due to the null replacement. Hence if the item is an array I iterate over it and splice the index that isn't required

alxAgu commented 2 years ago

Any chance of getting @alichherawalla 's commit merged? I'm having the exact same issue.

alichherawalla commented 2 years ago

@anantab Would it be possible to please review this PR?

alichherawalla commented 2 years ago

Thanks for the review @dapriett

Possible to please merge since I don't have write access

alichherawalla commented 1 year ago

@anantab @dapriett possible to please merge this in?

dapriett commented 1 year ago

Hi @alichherawalla, sorry for the late reply. Unfortunately, I'm not one of the maintainers. Doesn't appear this repo is still being maintained.

But your change looked good to me. I was running into the same issue.

kamilpp commented 1 year ago

Hi @anantab. Any chance we can get this or #42 get merged and published?