search

anantab / serverless-plugin-ifelse

A Serverless Plugin to write If Else conditions in serverless YAML file
69 stars 21 forks source link

Add the option to add attirbute #4

Closed elad-haz closed 5 years ago

anantab commented 5 years ago

@elad-haz Thank you for the PR. I actually did not include this feature on purpose. You can have the attribute in YML file and remove it when not required. I think it will reduce any chances of surprises. Let me know if you think this feature is necessary or if you have use case for it.

elad-haz commented 5 years ago

Hi,

I think there is no risk of surprise for giving the option to add any attribute in the plugin. It can gives a flexible way to reduce unnecessary attributes in some conditions.

For my use case, I use plugin that called serverless-sentry-lib. In the plugin they use configurations with defaults value if there are no environments variables exists. So, if I want, in a specific stage, to change the default and in all other stages not to, I can easily do it with your plugin and the change of adding new variables. This way I do not need to add unnecessary environments variables to my lambdas.