anantdgoel / ProjectFib

Chrome extension to flag fake news on Facebook. Built at HackPrinceton '16
https://www.projectfib.com
Open Software License 3.0
747 stars 180 forks source link

Problem with very generous resource sharing #13

Open thefangbear opened 8 years ago

thefangbear commented 8 years ago

Microsoft key: https://github.com/anantdgoel/HackPrincetonF16/blob/master/backend/imageverify.py#L178 IBM Watson cloud key: https://github.com/anantdgoel/HackPrincetonF16/blob/master/backend/imageverify.py#L161

Some wierd text API key: https://github.com/anantdgoel/HackPrincetonF16/blob/master/backend/imageverify.py#L151

Some webtrust key: https://github.com/anantdgoel/HackPrincetonF16/blob/master/backend/imageverify.py#L130

And finally, the App ID, key and secret of their Twitter app: https://github.com/anantdgoel/HackPrincetonF16/blob/master/backend/imageverify.py#L56

Also you guys are using regex to parse html? Not a very good idea.

https://github.com/anantdgoel/HackPrincetonF16/blob/master/backend/imageverify.py#L104

Finally since there's already a bunch of people who forked this repository it's meaningless for you to delete this repository but to request to change your API keys.

Thanks for your generosity again.

loretoparisi commented 8 years ago

Please deactivate each of those keys guys as soon as possible! Regarding HTML parsing, this it is not important (you could use python BeautifulSoap, PhantomJS, node jsdom or whatever) , you did a great job, and a great idea, how it is implemented does not matter at all. The idea to put all together all these Cognitive Services and the way you did it is extremely clever, so the rest does not matter! 💯 ^ 100

irufus commented 8 years ago

I think this has been brought up several times already. See #1

thefangbear commented 8 years ago

Please guys. Please deactivate the keys.