search

ananthakumaran / exunit.el

Emacs ExUnit test runner
42 stars 15 forks source link

Add ability to compile and run tests inside Docker container #3

Closed dcaixinha closed 11 months ago

dcaixinha commented 5 years ago

It would be great to be able to use exunit.el inside a Docker container.

Copying the idea from RSpec Mode, maybe exunit.el could have some parameters (such as exunit-use-docker-when-possible, exunit-docker-container, exunit-docker-command and exunit-docker-cwd) which would essentially turn the test commands prepended by docker exec -it <exunit-docker-container> bash -c "cd <exunit-docker-cwd> && <command_to_run_test> ".

What do you think?

dcaixinha commented 5 years ago

Hey @ananthakumaran, what does the 'PR accepted' label mean? You would accept such contribution? My Emacs Lisp-fu is quite weak, but I think I can copy the approach they had in RSpec mode and open the PR to get some feedback. Sounds good?

ananthakumaran commented 5 years ago

Yes, go ahead and open a PR. This library is mostly based on rspec mode.

On Fri, Mar 8, 2019, 5:24 AM Daniel Caixinha notifications@github.com wrote:

Hey @ananthakumaran https://github.com/ananthakumaran, what does the 'PR accepted' label mean? You would accept such contribution? My Emacs Lisp-fu is quite weak, but I think I can copy the approach they had in RSpec mode and open the PR to get some feedback. Sounds good?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ananthakumaran/exunit.el/issues/3#issuecomment-470721507, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJG9hodS5cgwwKo6-q7-eu23Go9-cUiks5vUZF_gaJpZM4be3i- .

dcaixinha commented 5 years ago

Hey @ananthakumaran, I now have a working version of exunit.el running the tests inside a docker container! :tada: while developing this I realized how useful it would be if I could also access any breakpoints I have set when debugging tests.

Since this is using a compilation buffer, the code stops there but then I can't access it. Do you have any idea / suggestion on how this would be possible? FYI I've manually created an eshell on the side and input the same command, and there I can interact with the breakpoint. Thanks :raised_hands:

ananthakumaran commented 5 years ago

I tried to debug the issue, but seems like too many things going on.

1) TERM is set to dumb by default, which results in IEx not able to start 2) If I change the TERM, it still could not read input.

I haven't spend much time to find the root cause so far.