search

ananthakumaran / monky

Magit for Hg
http://ananthakumaran.in/monky/index.html
GNU General Public License v3.0
154 stars 30 forks source link

move log buffer after showing commit #28

Closed tkf closed 12 years ago

tkf commented 12 years ago

This change fixed a problem in monky-goto-next-section: As (monky-show-commit next) takes a little time, previous version "shakes" when go down to the commit which is in the next page.

By the way, why do you need recenter in monky-goto-next-section? You don't have it in monky-goto-previous-section, right? I also think current behavior is a little bit strange because hitting n always moves the next section at the bottom if possible (i.e., there is a space to scroll down), even if the current section was not at the bottom. You can check if the current section is at the bottom or not before moving the cursor, but I think it introduces unnecessary complexity. I think removing (recenter offset) is better solution. What do you think?

tkf commented 12 years ago

I just wrote the patch (#29) for another solution. Please pull the one you like!