ananthakumaran / monky

Magit for Hg
http://ananthakumaran.in/monky/index.html
GNU General Public License v3.0
154 stars 30 forks source link

New features #51

Closed kuribas closed 6 years ago

kuribas commented 6 years ago

Hi, I implemented some new features that I found useful

I removed fetch, because it's a deprecated command.

ananthakumaran commented 6 years ago

I don't have time to review new feature PRs (I very rarely use hg nowadays). @lbolla has commit access. I am actually looking for more maintainers, if you could get somebody to review and test it, I could give you commit access.

kuribas commented 6 years ago

Thanks, but I haven't found anyone in the small intersection of emacs-lisp programmers and mercurial users...

juszczakn commented 6 years ago

I use it at work, I might be able to take a look at this later, no promises though.

Bounga commented 6 years ago

@ananthakumaran @kuribas I'd love to review and test this. I use Mercurial on a daily basis for my personal stuff so I'd be glad to see improvements making their way into Monky.

ananthakumaran commented 6 years ago

@Bounga @kuribas I have given commit access to both of you guys. Feel to free merge once tested. It's already in melpa, so merging to master will make it available for everyone.

Bounga commented 6 years ago

@ananthakumaran Thanks a lot. I'll take time to test things available in PR and merge them if it's working well and useful.

muffinmad commented 6 years ago

Optional run update after a pull (with a customizable variable)

Can it be configured to run rebase after pull?

Bounga commented 6 years ago

@muffinmad Just had a look at the code and it seems like it would be easy to add this option.

Bounga commented 6 years ago

@kuribas Would you mind to resolve the conflict and maybe add the option @muffinmad is talking about or do you prefer that I do this by myself?

kuribas commented 6 years ago

I'll have a look at it

kuribas commented 6 years ago

@muffinmad can you try if it does what you want? Feel free to commit when you're satisfied.

muffinmad commented 6 years ago

@kuribas sure, no problem. I think it will be better to make separate PR.

Bounga commented 6 years ago

Gonna try it too this week end

kuribas commented 6 years ago

I added the tool option because it worked rather badly with the default settings. I expect a tool to work well out of the box, and to be able to change it. Perhaps this should be an option as well?

muffinmad commented 6 years ago

@kuribas monky-pull-args option can solve it. Also there are monky-hg-standart-options variable. By default it can include "--config" "ui.merge=:merge".

muffinmad commented 6 years ago

I use this branch as primary mercurial tool. No issues so far.

Bounga commented 6 years ago

@muffinmad Nice. however it would be great to avoid the hardcoded merge tool before merging.

muffinmad commented 6 years ago

@Bounga indeed

kuribas commented 6 years ago

Make it an option as well? It'd be nice to have a sensible default for emacs.

muffinmad commented 6 years ago

@kuribas We already have monky-hg-standart-options where one can specify "--config" "ui.merge=:merge". I think one merge tool for all monky commands it's enough for the moment. Hardcoded merge tool can be safely deleted from monky-merge.

Bounga commented 6 years ago

LGTM Think we can merge now.

kuribas commented 6 years ago

Fine for me