search

ananthakumaran / monky

Magit for Hg
http://ananthakumaran.in/monky/index.html
GNU General Public License v3.0
154 stars 30 forks source link

Prefer user-error for things that aren't bugs in monky #63

Closed Wilfred closed 5 years ago

Wilfred commented 5 years ago

There's no point opening a debugger in cases when the user is trying to do something wrong.

Bounga commented 5 years ago

LGTM gonna merge. By reviewing this I noticed that some of the error messages ends with a dot which is against Emacs guidelines:

In Emacs, the convention is that error messages start with a capital letter but do not end with a period. Please follow this convention for the sake of consistency.

We maybe should open an issue to change this.

Wilfred commented 5 years ago

It's probably worth fixing, but the consequences of breaking this particular convention are very minor :)