'Diff' in commit messages confuses monky

ananthakumaran / monky

Magit for Hg

http://ananthakumaran.in/monky/index.html

GNU General Public License v3.0

154 stars 30 forks source link

'Diff' in commit messages confuses monky #68

Open Wilfred opened 6 years ago

Wilfred commented 6 years ago

Given the following commit:

$ hg show
changeset:   c3b6a6540e61c13c0a1e9da773b5a2174557ee72   (@)
user:        Wilfred Hughes <me@wilfred.me.uk>
date:        Fri, 21 Sep 2018 14:20:20 +0100

    An example commit

    Differences are important.

    Hello world.

diff -r 718f54d8eb02 -r c3b6a6540e61 README
--- a/README    Fri Sep 21 14:17:55 2018 +0100
+++ b/README    Fri Sep 21 14:20:20 2018 +0100
@@ -1,1 +1,1 @@
-new content!
+new content again

Monky is confused by 'Differences':

screen shot 2018-09-21 at 14 21 08

Bounga commented 6 years ago

Oh wow! Good catch!

Seems like we're using a regex that is overly permissive.

Bounga commented 6 years ago

I think we can close this one even if the new matching provided in #70 isn't bullet proof.

Wilfred commented 6 years ago

My preference is to leave it open until we have a fully correct solution, but I don't mind :)

Wilfred commented 6 years ago

Aha, hg log -Tjson would give us bullet proof parsing.