search

ananthakumaran / monky

Magit for Hg
http://ananthakumaran.in/monky/index.html
GNU General Public License v3.0
154 stars 30 forks source link

Fix lexical-binding and namespace #81

Closed Wilfred closed 5 years ago

Wilfred commented 5 years ago

Add lexical binding, and fix a variable without a namespace.

Wilfred commented 5 years ago

@Bounga thank you :)

If you're happy with me just committing small changes directly to master, I'm happy to do that. Let me know what you prefer.

Bounga commented 5 years ago

You're welcome. Sorry but I'm not admin on this repo I have commit rights only.

Wilfred commented 5 years ago

@Bounga sorry, I was unclear. Now I have commit access, I can make changes directly without creating pull requests. Are you happy me committing changes directly to master?

Bounga commented 5 years ago

@Wilfred oh sorry! If it's a small change that can be made in one small atomic commit and that this change is relevant to all users then yes go ahead. If it's a larger feature then I think that it's better to create a PR so it can be discussed, reviewed and it makes the git history cleaner thanks to the dedicated branch that will eventually be merged.

You've been very prolific lately and your work clearly makes Monky a better package so I think you can legitimately push things by yourself when it makes sense 😉.