ananthakumaran / paisa

Paisa – Personal Finance Manager. https://paisa.fyi demo: https://demo.paisa.fyi
https://paisa.fyi
GNU Affero General Public License v3.0
2.34k stars 117 forks source link

Saving import template sometimes causes an error popup to show, and the app dies #117

Open tonnydourado opened 7 months ago

tonnydourado commented 7 months ago

Describe your Environment OS: Windows 10 Paisa Version: 0.6.2 App Variant: Desktop

Describe the bug Sometimes, when saving an import template, I get this error:

Paisa Error Screenshot 2023-12-28 233057

And then the app closes, usually loosing any edits in the template.

To Reproduce Steps to reproduce the behavior: Not quite sure. Sometimes, I re-open the app and paste the exact same template, and click save, and it works.

Expected behavior I would expect that syntax errors on an import template would not kill the app

Screenshots Screenshot is in the description

Journal I don't have any data in the journal.

ananthakumaran commented 7 months ago

@tonnydourado to give some context, the error is about a newly introduced config field called strict. Since the templates are stored in the config file, any update to the config file will trigger the validation and for some reason, strict field validation is failing. Could you look into paisa.yaml and check what's the current value of strict. I am still not sure what sequence of actions could lead to this error. Let me also know if you switched back to an older version of Paisa after the upgrade by any chance.

tonnydourado commented 7 months ago

@ananthakumaran I have had strict: "no", pretty much from the start, and it still happens, sometimes. I also only ever used the latest version.

ananthakumaran commented 7 months ago

Though the error is very obvious (it tries to save strict with some value other than yes/no/""), I am not sure how it will go to that state. I had a quick look at the code, but I can't find any obvious mistake so far. If you could find a way to reproduce the error reliably, that would be very useful.