hledger: unbreak total (@@) behavior with double currency conversion

ananthakumaran / paisa

Paisa – Personal Finance Manager. https://paisa.fyi demo: https://demo.paisa.fyi

https://paisa.fyi

GNU Affero General Public License v3.0

2.34k stars 117 forks source link

hledger: unbreak total (@@) behavior with double currency conversion #138

Closed valpackett closed 7 months ago

valpackett commented 7 months ago

I thiiiink this should always be correct :)

I've been hitting the case where amount.Price.Contents.Commodity != config.DefaultCurrency() but amount.Price.Tag == "TotalPrice" (say 1 ARS @@ 1070 USD, when default currency is not USD and a second conversion to that from USD is expected) and ending up with confused currencies in the reports. This patch makes it so that amount.Price.Tag is always considered, not only in the default currency case.

github-actions[bot] commented 7 months ago

I do not plan to accept any pull request for now. If you have a feature request, start a discussion, or if you found a bug, create a new issue.

ananthakumaran commented 7 months ago

This is fixed on the master, please consider opening an issue next time. contribution policy