search

ananthakumaran / tide

Tide - TypeScript Interactive Development Environment for Emacs
GNU General Public License v3.0
1.46k stars 109 forks source link

Treesitter support #458

Closed kijowski closed 1 year ago

kijowski commented 1 year ago

This PR removes hard dependency on typescript-mode and adds support to treesitter based typescript-ts-mode (it keeps support for typescript-mode)

typescript-mode has been used directly only for indentation and after changing calls from typescript-indent-line to indent-according-to-mode we can safely remove hard dependency and support treesitter based modes at the same time.

kijowski commented 1 year ago

I can see that CI build for 27.2 failed, but it looks like there was a problem with melpa connectivity. I think that after rerunning it there should not be any errors.

sandinmyjoints commented 1 year ago

When I switch to typescript-ts-mode, tide-company no longer has any completions. Is anyone else seeing this problem?

josteink commented 1 year ago

Have you added the new hook as outlined in the readme?

sandinmyjoints commented 1 year ago

Yes, tide-setup is in my typescript-ts-mode-hook, and I can see that tide-mode is enabled in my TS buffers. Company as well -- I get completions from other backends.