search

ananthbh / SurveyList

0 stars 0 forks source link

Regarding unused property #18

Open teamdisc opened 6 years ago

teamdisc commented 6 years ago

This is my last issue here and it's no big deal. I saw that there's some property left unused, but perhaps you have your plan on what to do next, but I'd just like to point this out, in case you miss it. E.g. NetworkProvider is not used in SurveyDetailViewModel so perhaps we could remove it 😉

ananthbh commented 6 years ago

I had done this more for scalability reasons, which is not needed at the moment. Just more in terms of creating SurveyDetailViewModel. Which is actually not needed as SurveyViewModel can be used for it as we pass the same properties in the init as of SurveyViewModel.